Many years ago, I took part in the development of a taxi-hailing mobile app that is still widely used today. I don’t know what kind of code they’re running now, but in those early days, the driver assignment code –if I remember it correctly– was similar in spirit to the grossly simplified example that follows. There are five levels of nested if statements in less than 30 lines of code. It doesn’t look so bad, some might say, but it’s not difficult to imagine how complicated this code can become with just a few more checks…
  • @djnattyp@lemmy.world
    3•7 months ago

    Google for “replace conditional with polymorphism”.

    Just checked and it is in “Clean Code” - Chaper 17; Section G23 “Prefer Polymorphism to if/else or switch/case”.

    • @FizzyOrange@programming.dev
      4•7 months ago

      This is really terrible advice. Sometimes it’s better to do that, but definitely not in the example from this article.

      If anyone says you should always prefer polymorphism to switches they are a bloody idiot.

      • @PushButton@lemmy.world
        3•7 months ago

        I always love watching people falling for Clown-Bob’s advises…

        Let’s go, let’s eat shit on toasts! It’s just a matter of how thin you can spread it to hide the taste…